Android studio github incorrect credentials

GitHub credentials incorrect #22

Comments

herman-rogers commented Mar 26, 2019 •

So just parking fairly common issue, since we can only specify git credentials using our username and password this method will fail if you have 2-factor authentication setup. The simple work around is just to disable 2-factor in your account and the proper fix is to allow using ssh authentication (I don’t think at the moment 2-factor for GitHub is enabled via cli but I might be wrong).

The text was updated successfully, but these errors were encountered:

TBBle commented Mar 27, 2019

You can generate a Personal Access Token to use as a password in this case.

adamrehn commented Mar 27, 2019

Thanks @TBBle, it’s good to know that the access token option is available for users who have 2FA enabled. I’ve added a note about it to the documentation to make it easier for people to find.

Support for SSH authentication is an interesting option, although it would require a bit of a re-think in terms of how the credential manager is implemented. I’ll have a look into how feasible it would be to add an option for it and post a comment here with my findings.

herman-rogers commented Mar 27, 2019

Thanks for the tip @TBBle — I’ll definitely go down that route in the meantime!

TBBle commented Mar 28, 2019

Would the credential manager rethink be easier if it was implemented as a Credential Helper rather than SSH_ASKPASS helper? I’m not totally clear if there’s a difference in functionality there, as SSH_ASKPASS doesn’t appear clearly-documented.

I’ve been thinking about this myself. My use-case is running on AWS, but if I was running this locally, then I’d like it to read from my SSH Agent in the SSH case.

And at some point, I suspect I’ll need to be able to source from Perforce rather than git, which can work off user/pass and off tickets. Perforce is probably distinct-enough that it would need its own credential-managing approach anyway, so that’s low-value here.

adamrehn commented May 9, 2019

@TBBle evidently forwarding of SSH credentials is now possible using experimental build features in the latest builds of Docker: https://medium.com/@tonistiigi/build-secrets-and-ssh-forwarding-in-docker-18-09-ae8161d066

Once BuildKit becomes the default build implementation for Docker and support is added for Windows containers, I’ll revisit the credential management code in ue4-docker and overhaul it to use the new functionality, which should allow for a far wider variety of authentication mechanisms and source control systems.

qhaas commented Oct 10, 2019

Thanks for the personal access token lead. Also, would be handy to be able to point ue4-docker at a directory location on the host system where the ue4 repository has already been cloned so no authentication will be necessary.

adamrehn commented Oct 11, 2019

@qhaas yeah, the option to use a local filesystem directory was discussed in #47 and I agree that it could be handy for certain use cases. Support for flexible and pluggable code sources is one of the goals of the big redesign of the project being discussed in #48.

fiercefairy commented May 21, 2020

It looks like even using no 2 factor or a personal access token fails:

adamrehn commented May 23, 2020

Strange, I got an email notification for a follow-up comment by @fiercefairy, but it’s not showing up here in the actual issue thread. Posting for posterity:

nevermind. If you have email privacy enabled, you have to use the full masked username + @users.noreply.github.com email found in your profile settings as your username

olitazl commented Sep 1, 2020 •

I got this problem

and fixed it by starting ue4-docker build. After the start, I did not enter the credentials at first but edit the git-credentials-helper.sh in the tmp folder the follows:

After the change hit Enter at the credentials and the docker image will build. I just used it with a one time personal access token.

This helped. The problem seems to be with the server binding delivering the password to the docker image.

slonopotamus commented May 19, 2021 •

Note: starting with 13 August, 2021 it will no longer be possible to authenticate using login/password. https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/
But we will still be able to use Personal Access Token thing: #22 (comment)

peters-arrival commented Aug 27, 2021

I’ve been trying to get our ue4-docker builds into our CI/CD process, but I am getting the «not found» error. I have created a personal access token, with basically no rights ( read only ).

Are there specific oath settings that credential needs to have in order to properly use the personal access token in place of the old password system?

Cloning into ‘/home/ue4/UnrealEngine’. remote: Repository not found. fatal: repository ‘https://github.com/EpicGames/UnrealEngine.git/’ not found The command ‘/bin/sh -c git clone —progress —depth=1 -b $GIT_BRANCH $GIT_REPO /home/ue4/UnrealEngine && echo » && echo ‘RUN directive complete. Docker will now commit the filesystem layer to disk.’ && echo ‘Note that for large filesystem layers this can take quite some time.’ && echo ‘Performing filesystem layer commit. ‘ && echo »’ returned a non-zero code: 128 [ue4-docker build] Error: failed to build image «adamrehn/ue4-source:4.26.1-opengl».

TBBle commented Aug 28, 2021

Have you tested that you can use your token to clone the repo using git clone https://github.com/EpicGames/UnrealEngine.git ?

The docs suggest you’d need the repo scope, and I don’t see a way to say «Read-only access to private repos» there.

peters-arrival commented Aug 28, 2021

Yeah thanks for responding. Like you said, it looks like private repos need more aggressive permissions. I changed it to include all «repo» flags and everything is working now.

slonopotamus commented Sep 2, 2021

So, what we want from this issue? Password authentication is dead, everyone needs to use PATs now. We could rename all «password» occurences in ue4-docker sources and docs with «access token» (of course via deprecation path with warnings everywhere when you use old term).

TBBle commented Sep 3, 2021

That only applies if you’re talking to GitHub. Other providers and on-prem can still use passwords, or even not require authentication at all for cloning.

We could check for github.com in the URL and then say «PAT» instead of «password» in the UI, but that seems like more complexity than value.

slonopotamus commented Sep 3, 2021

Other providers and on-prem can still use passwords

Ah, true. So I guess we can just close this?

Источник